Bug 127443 - Web Inspector: Don't include a hidden Timeline selection in the navigation path components
Summary: Web Inspector: Don't include a hidden Timeline selection in the navigation pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-22 12:48 PST by Timothy Hatcher
Modified: 2014-01-22 14:58 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2014-01-22 12:53 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-22 12:48:56 PST 
When filtering happens, we don't want to keep showing the selection in the navigation bar.
Comment 1 Radar WebKit Bug Importer 2014-01-22 12:49:38 PST 
<rdar://problem/15883887>
Comment 2 Timothy Hatcher 2014-01-22 12:53:49 PST 
Created attachment 221895 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-22 13:10:42 PST 
Comment on attachment 221895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221895&action=review

r=me

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:47
> +        if (!previousSibling)
>              return null;

This early return can be removed, since the loop below will check if previousSibling and do the right thing.

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:62
> +        if (!nextSibling)
>              return null;

Ditto
Comment 4 Timothy Hatcher 2014-01-22 14:58:23 PST 
https://trac.webkit.org/r162561