RESOLVED FIXED 127443
Web Inspector: Don't include a hidden Timeline selection in the navigation path components 
https://bugs.webkit.org/show_bug.cgi?id=127443
Summary Web Inspector: Don't include a hidden Timeline selection in the navigation pa...
Timothy Hatcher
Reported 2014-01-22 12:48:56 PST
When filtering happens, we don't want to keep showing the selection in the navigation bar.
Attachments
Patch (7.04 KB, patch)
2014-01-22 12:53 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-22 12:49:38 PST
<rdar://problem/15883887>
Timothy Hatcher
Comment 2 2014-01-22 12:53:49 PST
Created attachment 221895 [details] Patch
Joseph Pecoraro
Comment 3 2014-01-22 13:10:42 PST
Comment on attachment 221895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221895&action=review r=me > Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:47 > + if (!previousSibling) > return null; This early return can be removed, since the loop below will check if previousSibling and do the right thing. > Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:62 > + if (!nextSibling) > return null; Ditto
Timothy Hatcher
Comment 4 2014-01-22 14:58:23 PST
https://trac.webkit.org/r162561
Note You need to log in before you can comment on or make changes to this bug.