Bug 127442 - PutByIdDirect in FTL
Summary: PutByIdDirect in FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 12:31 PST by Matthew Mirman
Modified: 2014-01-24 13:15 PST (History)
2 users (show)

See Also:

Attachments
Adds PutByIdDirect capabilities to FTL (3.02 KB, patch)
2014-01-22 12:35 PST, Matthew Mirman 		no flags Details | Formatted Diff | Diff
Adds PutByIdDirect capabilities to FTL (3.04 KB, patch)
2014-01-22 12:41 PST, Matthew Mirman 		fpizlo: review-
fpizlo: commit-queue-
Details | Formatted Diff | Diff
PutByIdDirect in FTL patch (2.61 KB, patch)
2014-01-24 12:44 PST, Matthew Mirman 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2014-01-22 12:31:48 PST 
patch forthcoming
Comment 1 Matthew Mirman 2014-01-22 12:35:25 PST 
Created attachment 221892 [details]
Adds PutByIdDirect capabilities to FTL

also adds a test for PutById
Comment 2 WebKit Commit Bot 2014-01-22 12:36:53 PST 
Attachment 221892 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyiddirect.js:11:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:5:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-putbyid.js:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Matthew Mirman 2014-01-22 12:41:56 PST 
Created attachment 221893 [details]
Adds PutByIdDirect capabilities to FTL

Also adds a test for PutById.
Comment 4 Filip Pizlo 2014-01-24 12:36:18 PST 
Comment on attachment 221893 [details]
Adds PutByIdDirect capabilities to FTL

View in context: https://bugs.webkit.org/attachment.cgi?id=221893&action=review

This looks good but please revert the whitespace changes.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-30
> -

Revert!  We generally try to minimize whitespace changes, especially in otherwise small patches.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1518
> +

Revert!
Comment 5 Matthew Mirman 2014-01-24 12:44:37 PST 
Created attachment 222140 [details]
PutByIdDirect in FTL patch

Removed whitespace, added test for putbyid.
Comment 6 Filip Pizlo 2014-01-24 13:15:29 PST 
Landed in http://trac.webkit.org/changeset/162717