When a resource is collapsed the call site records should be shown on the resource row.
<rdar://problem/15883420>
Created attachment 221888 [details] Patch
Created attachment 221891 [details] Screenshot
Comment on attachment 221888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221888&action=review r=me > Source/WebInspectorUI/ChangeLog:24 > + Add a shadow to provide some negative space between juxtaposed records. Only needed when not expanded and not netwrok records. Typo: netwrok > Source/WebInspectorUI/ChangeLog:69 > + Tweaked styles to look bettwen when selected. Typo: bettwen => better > Source/WebInspectorUI/UserInterface/OverviewTimelineView.js:104 > + // Check the filters again since the current time change might have revealed this node. Start and end time canges are handled by TimelineContentView. Typo: canges => ranges > Source/WebInspectorUI/UserInterface/OverviewTimelineView.js:105 > + WebInspector.timelineSidebarPanel.updateFilter(); Maybe you can have an updateFilter(oldCurrentTime) and only need to update records that came after oldCurrentTime to hopefully reduce the amount of work. > Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:67 > + collapse: function() Can each of these (collapse, expand, appendChild, insertChild, etc.) call this.needsGraphRefresh instead of this.refreshGraph to combine potential multiple updates. If that is the case, you can remove the if (!this._graphDataSource) check because needsGraphRefresh does that for you. > Source/WebInspectorUI/UserInterface/TimelineDataGridNode.js:371 > + for (var childNode of this.children) { > + if (!(childNode instanceof WebInspector.TimelineDataGridNode)) > + continue; This only goes 1 level deep. I would not have expected that. E.g. if someone collapses a main resource (index.html in the screenshot) I would expect all the bubbles to bubble up into one row. This for loop would need to be a recursive function willing to dig deeper.
I made it recursive and removed the need for appendChild, insertChild, etc. https://trac.webkit.org/r162560
Follow up: https://trac.webkit.org/r162564