RESOLVED FIXED 127433
Add WKProcessClass class 
https://bugs.webkit.org/show_bug.cgi?id=127433
Summary Add WKProcessClass class
Anders Carlsson
Reported 2014-01-22 11:06:45 PST
Add WKProcessClass class
Attachments
Patch (9.53 KB, patch)
2014-01-22 11:08 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (13.64 KB, patch)
2014-01-22 11:13 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (11.92 KB, patch)
2014-01-22 11:15 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-22 11:08:02 PST
Created attachment 221877 [details] Patch
Anders Carlsson
Comment 2 2014-01-22 11:13:11 PST
Created attachment 221878 [details] Patch
Anders Carlsson
Comment 3 2014-01-22 11:15:24 PST
Created attachment 221880 [details] Patch
Anders Carlsson
Comment 4 2014-01-22 11:22:10 PST
Committed r162541: <http://trac.webkit.org/changeset/162541>
Darin Adler
Comment 5 2014-01-22 15:27:58 PST
Comment on attachment 221880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221880&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:42 > + _configuration = adoptNS([configuration copy]); copy > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:51 > + return [[_configuration copy] autorelease]; Why do we need copy/autorelease here if we did a copy in the initializer.
Anders Carlsson
Comment 6 2014-01-22 16:52:25 PST
(In reply to comment #5) > (From update of attachment 221880 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221880&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:42 > > + _configuration = adoptNS([configuration copy]); > > copy From the documentation: The initializer copies @link //apple_ref/doc/methodparam/WKProcessClass/initWithConfiguration:/configuration configuration@/link, so mutating it after initialization has no effect on the @link WKProcessClass @/link instance. > > > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:51 > > + return [[_configuration copy] autorelease]; > > Why do we need copy/autorelease here if we did a copy in the initializer. From the documentation: /*! @abstract A copy of the configuration with which the @link WKProcessClass @/link was initialized. */
Note You need to log in before you can comment on or make changes to this bug.