Bug 127428 – [WK2] Unskip now passing tests after r135595

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

wk2/TestExpectations:

# WebKitTestRunner needs eventSender.contextClick()
# https://bugs.webkit.org/show_bug.cgi?id=86881
editing/selection/context-menu-text-selection.html
editing/selection/5354455-2.html
fast/events/context-nodrag.html


r135595 implemented the missing featurea, additionally
I tested them on EFL WK2 and they are passing now.

[Csaba Osztrogonác]

Created attachment 221868 [details]
Patch

Let's see what the Mac WK2 EWS think about it.

[Build Bot]

Comment on attachment 221868 [details]
Patch

Attachment 221868 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6356663871209472

New failing tests:
editing/selection/context-menu-text-selection.html

[Build Bot]

Created attachment 221871 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Csaba Osztrogonác]

Created attachment 221965 [details]
Patch

maybe it was flakiness

[Build Bot]

Comment on attachment 221965 [details]
Patch

Attachment 221965 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5454781204135936

New failing tests:
editing/selection/context-menu-text-selection.html

[Build Bot]

Created attachment 221968 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Csaba Osztrogonác]

Created attachment 221969 [details]
Patch

No, it wasn't flakiness, editing/selection/context-menu-text-selection.html really crashes on Mac WK2, so let's skip it on mac-wk2. And I filed a bug report about this crash: https://bugs.webkit.org/show_bug.cgi?id=127473

[Csaba Osztrogonác]

Created attachment 250057 [details]
Patch

patch for EWS

[Build Bot]

Comment on attachment 250057 [details]
Patch

Attachment 250057 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5390905636814848

New failing tests:
fast/fixed-layout/fixed-layout.html

[Build Bot]

Created attachment 250062 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Csaba Osztrogonác]

Comment on attachment 250057 [details]
Patch

Clearing flags on attachment: 250057

Committed r182316: <http://trac.webkit.org/changeset/182316>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

I re-skipped two tests in r182322.

It doesn't seem worth keeping them enabled with a Timeout expectation - that has a pretty high cost, as one process has to wait 30 seconds.

[Csaba Osztrogonác]

(In reply to comment #13)
> I re-skipped two tests in r182322.
> 
> It doesn't seem worth keeping them enabled with a Timeout expectation - that
> has a pretty high cost, as one process has to wait 30 seconds.

There are 7 tests in mac and 11 in mac-wk2's TestExpectations marked
as timeout, I thought it is common for Mac platforms. (Otherwise I
I always prefered skipping tests instead of marking timeout, fail, etc.,
because small ports didn't care about fixing any regression in my 
6.5 years working on WebKit. So why run always failing tests? :)) )