Bug 127415 - PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
Summary: PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-22 01:19 PST by Tim Horton
Modified: 2014-01-27 16:03 PST (History)
4 users (show)

See Also:

Attachments
patch (37.95 KB, patch)
2014-01-22 01:36 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
rebase (38.04 KB, patch)
2014-01-22 01:43 PST, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-22 01:19:56 PST 
If there is an external PDF plugin but it's blocked, we should still load in PDFPlugin, with a context menu option to perform the equivalent of the unavailable plugin button (thus allowing the client to unblock the plugin).

<rdar://problem/12482452>
Comment 1 Tim Horton 2014-01-22 01:36:39 PST 
Created attachment 221837 [details]
patch

I hate adding more things to findPlugin and pluginLoadPolicy but it is the most straightforward way to go.
Comment 2 Tim Horton 2014-01-22 01:43:05 PST 
Created attachment 221839 [details]
rebase
Comment 3 Sam Weinig 2014-01-23 07:47:33 PST 
Comment on attachment 221839 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review

> Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396
> +    // Version 4.
> +    WKPageWebGLLoadPolicyCallback                                       webGLLoadPolicy;
> +
> +    // Version 5.
> +    WKPagePluginLoadPolicyCallback                                      pluginLoadPolicy;

I'm not clear if we need to rev for this.
Comment 4 Tim Horton 2014-01-23 11:08:32 PST 
(In reply to comment #3)
> (From update of attachment 221839 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221839&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPageLoaderClient.h:396
> > +    // Version 4.
> > +    WKPageWebGLLoadPolicyCallback                                       webGLLoadPolicy;
> > +
> > +    // Version 5.
> > +    WKPagePluginLoadPolicyCallback                                      pluginLoadPolicy;
> 
> I'm not clear if we need to rev for this.

Looks like you’re right.
Comment 5 Tim Horton 2014-01-23 11:27:10 PST 
http://trac.webkit.org/changeset/162629
Comment 6 Tim Horton 2014-01-27 16:03:39 PST 
Part of this was reverted in https://trac.webkit.org/r162883