Bug 127407 - CStack Branch: Fix DFG for X86-32
Summary: CStack Branch: Fix DFG for X86-32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 22:50 PST by Michael Saboff
Modified: 2014-01-22 09:15 PST (History)
0 users

See Also:


Attachments
Patch (19.17 KB, patch)
2014-01-21 23:08 PST, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-01-21 22:50:59 PST
This is to make the appropriate changes so the DFG  will build and run on X86-32.  This will likely require changes in other engines as well.
Comment 1 Michael Saboff 2014-01-21 23:08:29 PST
Created attachment 221830 [details]
Patch

With this patch X86-32 runs the JSC stress tests with 20 errors.
** The following JSC stress test failures have been introduced:
	v8-v6/v8-crypto.js.dfg-eager
	v8-v6/v8-crypto.js.dfg-eager-no-cjit-validate
	regress/script-tests/fold-double-to-int.js.default
	regress/script-tests/fold-double-to-int.js.no-llint
	regress/script-tests/fold-double-to-int.js.always-trigger-copy-phase
	regress/script-tests/fold-double-to-int.js.no-cjit-validate-phases
	regress/script-tests/fold-double-to-int.js.dfg-eager
	regress/script-tests/fold-double-to-int.js.dfg-eager-no-cjit-validate
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.default
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.no-llint
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.always-trigger-copy-phase
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.no-cjit-validate-phases
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.dfg-eager
	regress/script-tests/Int16Array-bubble-sort-with-byteLength.js.dfg-eager-no-cjit-validate
	regress/script-tests/Int16Array-bubble-sort.js.default
	regress/script-tests/Int16Array-bubble-sort.js.no-llint
	regress/script-tests/Int16Array-bubble-sort.js.always-trigger-copy-phase
	regress/script-tests/Int16Array-bubble-sort.js.no-cjit-validate-phases
	regress/script-tests/Int16Array-bubble-sort.js.dfg-eager
	regress/script-tests/Int16Array-bubble-sort.js.dfg-eager-no-cjit-validate

Results for JSC stress tests:
    20 failures found.
Comment 2 Michael Saboff 2014-01-22 09:15:10 PST
Committed r162521: <http://trac.webkit.org/changeset/162521>