Bug 127398 - [wk2] De-.get()ify receivers of Objective-C messages
Summary: [wk2] De-.get()ify receivers of Objective-C messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 20:20 PST by Tim Horton
Modified: 2014-01-21 22:14 PST (History)
2 users (show)

See Also:


Attachments
patch (76.79 KB, patch)
2014-01-21 20:21 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-21 20:20:07 PST
RetainPtr does the right thing when you use it as the receiver of an Obj-C message, so we don't need .get().
Comment 1 Tim Horton 2014-01-21 20:21:11 PST
Created attachment 221821 [details]
patch

This, because I frequently get review comments about code nearby mine that uses .get() and have to go drive-by clean it up.
Comment 2 Sam Weinig 2014-01-21 21:20:19 PST
Comment on attachment 221821 [details]
patch

rs=me
Comment 3 WebKit Commit Bot 2014-01-21 22:13:59 PST
Comment on attachment 221821 [details]
patch

Clearing flags on attachment: 221821

Committed r162505: <http://trac.webkit.org/changeset/162505>
Comment 4 WebKit Commit Bot 2014-01-21 22:14:01 PST
All reviewed patches have been landed.  Closing bug.