Bug 127396 – WebKit2 View Gestures (Swipe): Give WebCore the first crack at scroll events if it needs it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

If a page has synchronous wheel event handlers, we should let it attempt to handle events before starting a swipe.

[Radar WebKit Bug Importer]

<rdar://problem/15876893>

[Tim Horton]

Created attachment 222501 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 222501 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222501&action=review

> Source/WebKit2/UIProcess/API/mac/PageClientImpl.h:118
> +    virtual void didNotHandleWheelEvent(const NativeWebWheelEvent&) override;

Who did not handle it? The receiver (the page client)?

[WebKit Commit Bot]

Attachment 222501 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:59:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 222504 [details]
patch

[Tim Horton]

Created attachment 222510 [details]
use NSEvent at the WKView level

[Tim Horton]

Created attachment 222513 [details]
remove unneeded fwd declaration

[Anders Carlsson]

Comment on attachment 222513 [details]
remove unneeded fwd declaration

View in context: https://bugs.webkit.org/attachment.cgi?id=222513&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:114
> +    bool m_hasDeferredSwipe;
> +    SwipeDirection m_deferredSwipeDirection;

I think pending would be more fitting than deferred here.

[Tim Horton]

http://trac.webkit.org/changeset/162984