Bug 127394 - JSC needs to be able to parse DWARF debug_line info
Summary: JSC needs to be able to parse DWARF debug_line info
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 18:18 PST by Mark Hahnenberg
Modified: 2014-02-04 13:22 PST (History)
7 users (show)

See Also:

Attachments
Patch (23.09 KB, patch)
2014-01-21 18:45 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (23.91 KB, patch)
2014-02-04 10:08 PST, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-01-21 18:18:57 PST 
If we want to encode IR maps in the DWARF debug line info metadata generated by LLVM, we'll need to know how to decode the .debug_line DWARF section.
Comment 1 Mark Hahnenberg 2014-01-21 18:45:23 PST 
Created attachment 221819 [details]
Patch
Comment 2 Mark Hahnenberg 2014-01-21 18:48:21 PST 
Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:281
> +        /* Special opcodes */

Unindent.
Comment 3 Sam Weinig 2014-01-21 21:25:43 PST 
Super-fun!
Comment 4 Geoffrey Garen 2014-01-28 09:15:01 PST 
Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

r=me

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:42
> +    T result = *(T*)program;

This should be "T result = *static_cast<const T*&>(program);"
Comment 5 Mark Hahnenberg 2014-02-04 10:08:01 PST 
Created attachment 223128 [details]
Patch
Comment 6 Mark Hahnenberg 2014-02-04 10:08:12 PST 
(In reply to comment #5)
> Created an attachment (id=223128) [details]
> Patch

EWS fodder.
Comment 7 Mark Hahnenberg 2014-02-04 10:17:49 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=223128) [details] [details]
> > Patch
> 
> EWS fodder.

Also forgot to fix the casts.
Comment 8 Geoffrey Garen 2014-02-04 12:37:28 PST 
Comment on attachment 223128 [details]
Patch

r=me
Comment 9 Mark Hahnenberg 2014-02-04 13:22:34 PST 
Committed r163397: <http://trac.webkit.org/changeset/163397>