Bug 127394 – JSC needs to be able to parse DWARF debug_line info

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

If we want to encode IR maps in the DWARF debug line info metadata generated by LLVM, we'll need to know how to decode the .debug_line DWARF section.

[Mark Hahnenberg]

Created attachment 221819 [details]
Patch

[Mark Hahnenberg]

Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:281
> +        /* Special opcodes */

Unindent.

[Sam Weinig]

Super-fun!

[Geoffrey Garen]

Comment on attachment 221819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221819&action=review

r=me

> Source/JavaScriptCore/ftl/FTLDWARFDebugLineInfo.cpp:42
> +    T result = *(T*)program;

This should be "T result = *static_cast<const T*&>(program);"

[Mark Hahnenberg]

Created attachment 223128 [details]
Patch

[Mark Hahnenberg]

(In reply to comment #5)
> Created an attachment (id=223128) [details]
> Patch

EWS fodder.

[Mark Hahnenberg]

(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=223128) [details] [details]
> > Patch
> 
> EWS fodder.

Also forgot to fix the casts.

[Geoffrey Garen]

Comment on attachment 223128 [details]
Patch

r=me

[Mark Hahnenberg]

Committed r163397: <http://trac.webkit.org/changeset/163397>