Bug 127391 - [WK2] add cocoa API for private browsing setting
Summary: [WK2] add cocoa API for private browsing setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alice Liu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 18:11 PST by Alice Liu
Modified: 2014-01-22 12:04 PST (History)
4 users (show)

See Also:


Attachments
patch (2.28 KB, patch)
2014-01-21 18:15 PST, Alice Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Liu 2014-01-21 18:11:48 PST
WK2 doesn't have Cocoa API for reading and writing the setting for private browsing.
Comment 1 Alice Liu 2014-01-21 18:15:49 PST
Created attachment 221818 [details]
patch
Comment 2 Alexey Proskuryakov 2014-01-22 09:54:04 PST
Comment on attachment 221818 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62
> +@property BOOL privateBrowsingEnabled;

Shouldn't this be private/deprecated because of sessions?
Comment 3 Alice Liu 2014-01-22 11:41:09 PST
(In reply to comment #2)
> (From update of attachment 221818 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62
> > +@property BOOL privateBrowsingEnabled;
> 
> Shouldn't this be private/deprecated because of sessions?

This possibly doesn't answer your question completely, but I was told to add this property to the browsingContextGroup as a temporary measure until websitedata api has been designed and fleshed out.  In other words, yes it is somewhat already deprecated considering near-future plans.
Comment 4 WebKit Commit Bot 2014-01-22 12:04:34 PST
Comment on attachment 221818 [details]
patch

Clearing flags on attachment: 221818

Committed r162546: <http://trac.webkit.org/changeset/162546>
Comment 5 WebKit Commit Bot 2014-01-22 12:04:37 PST
All reviewed patches have been landed.  Closing bug.