Bug 127391 – [WK2] add cocoa API for private browsing setting

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alice Liu]

WK2 doesn't have Cocoa API for reading and writing the setting for private browsing.

[Alice Liu]

Created attachment 221818 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 221818 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62
> +@property BOOL privateBrowsingEnabled;

Shouldn't this be private/deprecated because of sessions?

[Alice Liu]

(In reply to comment #2)
> (From update of attachment 221818 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221818&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:62
> > +@property BOOL privateBrowsingEnabled;
> 
> Shouldn't this be private/deprecated because of sessions?

This possibly doesn't answer your question completely, but I was told to add this property to the browsingContextGroup as a temporary measure until websitedata api has been designed and fleshed out.  In other words, yes it is somewhat already deprecated considering near-future plans.

[WebKit Commit Bot]

Comment on attachment 221818 [details]
patch

Clearing flags on attachment: 221818

Committed r162546: <http://trac.webkit.org/changeset/162546>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.