Bug 127363 - WebKit2 View Gestures: Fluid back-forward swipe
Summary: WebKit2 View Gestures: Fluid back-forward swipe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on: 127437 127438
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-21 12:27 PST by Tim Horton
Modified: 2014-01-27 12:18 PST (History)
5 users (show)

See Also:


Attachments
patch (73.07 KB, patch)
2014-01-21 16:51 PST, Tim Horton
no flags Details | Formatted Diff | Diff
take two (54.11 KB, patch)
2014-01-21 17:32 PST, Tim Horton
no flags Details | Formatted Diff | Diff
take three (54.99 KB, patch)
2014-01-21 18:05 PST, Tim Horton
no flags Details | Formatted Diff | Diff
mac build fix (55.00 KB, patch)
2014-01-22 11:23 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (won't build b/c of dependencies) (28.73 KB, patch)
2014-01-22 13:10 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (35.04 KB, patch)
2014-01-24 16:27 PST, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-21 12:27:03 PST
Implement fluid swipe as WebKit2 SPI. The initial implementation will be off by default, and has a few important features missing (I'll file bugs for them when this lands), including capping the number of snapshots, making them purgeable, and supporting web content overriding the swipe.
Comment 1 Tim Horton 2014-01-21 16:51:42 PST
Created attachment 221809 [details]
patch
Comment 2 WebKit Commit Bot 2014-01-21 16:53:02 PST
Attachment 221809 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:47:  The parameter name "webPageProxy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-01-21 16:55:41 PST
I'm going to do the rename in a separate patch to reduce the size.
Comment 4 Tim Horton 2014-01-21 17:32:43 PST
Created attachment 221814 [details]
take two
Comment 5 Tim Horton 2014-01-21 18:05:17 PST
Created attachment 221817 [details]
take three
Comment 6 Tim Horton 2014-01-22 11:23:22 PST
Created attachment 221882 [details]
mac build fix
Comment 7 Tim Horton 2014-01-22 12:10:14 PST
I'm splitting this patch up.
Comment 8 Tim Horton 2014-01-22 13:10:10 PST
Created attachment 221898 [details]
patch (won't build b/c of dependencies)
Comment 9 Tim Horton 2014-01-24 16:27:51 PST
Created attachment 222166 [details]
patch
Comment 10 Tim Horton 2014-01-24 23:50:16 PST
Comment on attachment 222166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74
> +

whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix
Comment 11 Anders Carlsson 2014-01-27 11:12:21 PST
Comment on attachment 222166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222166&action=review

>> Source/WebKit2/UIProcess/mac/ViewGestureController.mm:74
>> +
> 
> whoops, I forgot about this before posting the patch (and left the comment when I saw another patch in-flight). will fix

3_s!
Comment 12 Tim Horton 2014-01-27 12:18:19 PST
http://trac.webkit.org/changeset/162853