Bug 127347 - Delay initial layer flush during loading on all platforms
Summary: Delay initial layer flush during loading on all platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 07:57 PST by Antti Koivisto
Modified: 2014-01-21 14:04 PST (History)
6 users (show)

See Also:

Attachments
patch (3.86 KB, patch)
2014-01-21 08:02 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-21 07:57:21 PST 
To reduce unnecessary repaints enable the same behaviour as iOS already has.
Comment 1 Antti Koivisto 2014-01-21 08:02:04 PST 
Created attachment 221743 [details]
patch
Comment 2 Andreas Kling 2014-01-21 08:18:09 PST 
Comment on attachment 221743 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221743&action=review

Well that looked easy.
r=me

> Source/WebCore/rendering/RenderLayerCompositor.cpp:253
> -    , m_layerFlushThrottlingEnabled(false)
> +    , m_layerFlushThrottlingEnabled(page() && page()->progress().isMainLoadProgressing())

I wonder why page() returns a pointer, and not a reference.
Comment 3 Antti Koivisto 2014-01-21 08:40:08 PST 
https://trac.webkit.org/r162443
Comment 4 Simon Fraser (smfr) 2014-01-21 10:53:04 PST 
Does this mean we see a longer delay on back/forward before seeing the new page? Or is page cache navigation not affected?
Comment 5 Antti Koivisto 2014-01-21 14:04:24 PST 
(In reply to comment #4)
> Does this mean we see a longer delay on back/forward before seeing the new page? Or is page cache navigation not affected?

Page cache navigation shouldn't be affected. Completed load always turn off throttling.