Bug 127346 - Wrong struct size when CSS_IMAGE_ORIENTATION and CSS3_TEXT_DECORATION are enabled.
Summary: Wrong struct size when CSS_IMAGE_ORIENTATION and CSS3_TEXT_DECORATION are ena...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 127351
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-21 07:53 PST by László Langó
Modified: 2014-01-22 23:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2014-01-21 08:06 PST, László Langó 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description László Langó 2014-01-21 07:53:28 PST 
Source/WebCore/rendering/style/StyleRareInheritedData.cpp:68:1: error: static assertion failed: StyleRareInheritedData_should_bit_pack
Comment 1 László Langó 2014-01-21 08:06:26 PST 
Created attachment 221746 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-21 09:01:39 PST 
Comment on attachment 221746 [details]
Patch

Clearing flags on attachment: 221746

Committed r162445: <http://trac.webkit.org/changeset/162445>
Comment 3 WebKit Commit Bot 2014-01-21 09:01:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2014-01-21 09:17:08 PST 
Re-opened since this is blocked by bug 127351
Comment 5 Csaba Osztrogonác 2014-01-21 09:19:48 PST 
(In reply to comment #4)
> Re-opened since this is blocked by bug 127351

Rolled out, because it broke the 32 bit GTK build:

../../Source/WebCore/rendering/style/StyleRareInheritedData.cpp:68:1: error: static assertion failed: StyleRareInheritedData_should_bit_pack
 COMPILE_ASSERT(sizeof(StyleRareInheritedData) == sizeof(SameSizeAsStyleRareInheritedData), StyleRareInheritedData_should_bit_pack);

It seems there are different sized padding on 32 and 64 bit :-/