Bug 127332 - Shouldn't Failure expectation work for image-only failures?
Summary: Shouldn't Failure expectation work for image-only failures?
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 20:15 PST by Alexey Proskuryakov
Modified: 2016-04-11 10:18 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-20 20:15:40 PST
Failure allows for most kinds of failures, namely TEXT, IMAGE_PLUS_TEXT, and AUDIO. But why not image-only failures? Notably, one would expect that it works for reftests, I think.
Comment 1 Ryosuke Niwa 2014-01-20 20:52:24 PST
Yeah, I always disliked this.  Failure should include ImageOnlyFailure.
Comment 2 Dirk Pranke 2014-01-21 17:57:00 PST
There were discussions on this when we were talking about changing the syntax back in 6/12 (and then in 9/12 when the changes were landing).

The general theory (I think) was that if a test is failing the pixel results and starts failing the text results as well, that almost certainly is a regression that should be noticed (and, conversely, if a test is now only failing the pixel tests, that's an improvement that should be noticed). There was also the belief that this mattered more to the Chromium devs than others :).

Further, there were also debates as to whether reftests should be ImageOnlyFailure or just Failure. I don't think this one matters much one way or another.
Comment 3 Dirk Pranke 2014-01-21 17:57:15 PST
You are, of course, free to change it to however you'd like it to work these days.
Comment 4 Ryosuke Niwa 2016-04-11 01:16:10 PDT
Won't fixing this. Please re-open this bug if you feel strongly about it.
Comment 5 Alexey Proskuryakov 2016-04-11 09:52:11 PDT
Yes, people still get confused about this. In fact, the latest I heard someone complain was last week.
Comment 6 Ryosuke Niwa 2016-04-11 09:58:44 PDT
(In reply to comment #5)
> Yes, people still get confused about this. In fact, the latest I heard
> someone complain was last week.

Okay. This should be easy enough for someone in the tools' team to fix. I can give some guidance as needed.