Bug 12733 – XPath namespace is attached to a wrong step

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Alexey Proskuryakov]

When parsing paths such as "//svg:g[@id = 'r_00']", the namespace gets attached to the predicate, incorrectly resulting in something like "//g[@svg:id = 'r_00']".

[Alexey Proskuryakov]

Created attachment 13116 [details]
proposed fix

Suggestions are welcome on how to reduce code duplication in XPathGrammar.y. I thought about changing the type of NodeTest to a (string, namespace) pair, but this seemed unfair to other tests that do not use a namespace.

[Maciej Stachowiak]

Comment on attachment 13116 [details]
proposed fix

You could eliminate the duplication by adding an OptionalPredicateList production. r- to consider this, although your fix seems fine as-is.

[Alexey Proskuryakov]

Created attachment 13152 [details]
proposed fix

Thank you - did that!

[Darin Adler]

Comment on attachment 13152 [details]
proposed fix

The only reason I haven't marked this patch reviewed yet is that I'm not yet sure about the storage management in XPathGrammar.y -- I don't understand the rules about when a call to deleteString is needed and when it's not and I'd need to before I could mark this reviewed.

[Maciej Stachowiak]

Comment on attachment 13152 [details]
proposed fix

Darin has a good point. As it is, it looks like the YYABORT calls may leak. On the other hand, it looks to me like none of this is new with Alexey's patch. It might be worth investigating separately.

So r=me

[Sam Weinig]

Landed in r19684.