Bug 127326 – IC status classes should directly query exit site information

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

This consolidates all of the reasoning about whether or not to inline an IC at the IR level.

Patch forthcoming.

[Filip Pizlo]

Created attachment 221707 [details]
the patch

[WebKit Commit Bot]

Attachment 221707 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:581:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Landed in branch in http://trac.webkit.org/changeset/162424

[Geoffrey Garen]

Looks like the no DFG build needs some help:

     1>..\bytecode\CallLinkStatus.cpp(111): error C2039: 'hasExitSite' : is not a member of 'JSC::CodeBlock'
                 c:\cygwin\home\buildbot\webkit\source\javascriptcore\bytecode\CodeBlock.h(96) : see declaration of 'JSC::CodeBlock'
         ExitKind.cpp
     1>..\bytecode\CallLinkStatus.cpp(112): error C2039: 'hasExitSite' : is not a member of 'JSC::CodeBlock'
                 c:\cygwin\home\buildbot\webkit\source\javascriptcore\bytecode\CodeBlock.h(96) : see declaration of 'JSC::CodeBlock'
     1>..\bytecode\CallLinkStatus.cpp(113): error C2039: 'hasExitSite' : is not a member of 'JSC::CodeBlock'
                 c:\cygwin\home\buildbot\webkit\source\javascriptcore\bytecode\CodeBlock.h(96) : see declaration of 'JSC::CodeBlock'
     1>..\bytecode\CallLinkStatus.cpp(131): error C2039: 'hasExitSite' : is not a member of 'JSC::CodeBlock'
                 c:\cygwin\home\buildbot\webkit\source\javascriptcore\bytecode\CodeBlock.h(96) : see declaration of 'JSC::CodeBlock'
     1>c:\cygwin\home\buildbot\webkit\source\javascriptcore\assembler\X86Assembler.h(2348): warning C4309: 'argument' : truncation of constant value (..\bytecode\CodeBlockJettisoningWatchpoint.cpp)
         GetByIdStatus.cpp
         InlineCallFrameSet.cpp
         JumpTable.cpp
     1>c:\cygwin\home\buildbot\webkit\source\javascriptcore\assembler\X86Assembler.h(2348): warning C4309: 'argument' : truncation of constant value (..\bytecode\InlineCallFrameSet.cpp)
     1>c:\cygwin\home\buildbot\webkit\source\javascriptcore\assembler\X86Assembler.h(2348): warning C4309: 'argument' : truncation of constant value (..\bytecode\ExecutionCounter.cpp)
     1>c:\cygwin\home\buildbot\webkit\source\javascriptcore\assembler\X86Assembler.h(2348): warning C4309: 'argument' : truncation of constant value (..\bytecode\JumpTable.cpp)
     1>c:\cygwin\home\buildbot\webkit\source\javascriptcore\assembler\X86Assembler.h(2348): warning C4309: 'argument' : truncation of constant value (..\bytecode\GetByIdStatus.cpp)

[Geoffrey Garen]

Comment on attachment 221707 [details]
the patch

r=me with fixed build

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/162424