Bug 127321 - Removing CodeBlock::opDebugBytecodeOffsetForLineAndColumn() and friends.
Summary: Removing CodeBlock::opDebugBytecodeOffsetForLineAndColumn() and friends.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Blocks: 122836
  Show dependency treegraph
Reported: 2014-01-20 16:27 PST by Mark Lam
Modified: 2014-01-20 16:41 PST (History)
5 users (show)

See Also:

the patch. (18.10 KB, patch)
2014-01-20 16:31 PST, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-01-20 16:27:47 PST
We're changing plans and will be going with CodeBlock level breakpoints instead of bytecode level breakpoints.  As a result, we no longer need the services of CodeBlock::opDebugBytecodeOffsetForLineAndColumn() (and friends).  This patch will remove that unused code.
Comment 1 Mark Lam 2014-01-20 16:31:12 PST
Created attachment 221704 [details]
the patch.
Comment 2 Geoffrey Garen 2014-01-20 16:33:57 PST
Comment on attachment 221704 [details]
the patch.

Comment 3 Mark Lam 2014-01-20 16:41:20 PST
Thanks for the review.  Landed in r162389: <http://trac.webkit.org/r162389>.