Bug 127314 – Web Inspector: Add the recording button back to the Timelines sidebar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Add the recording button back and a clear button.

[Radar WebKit Bug Importer]

<rdar://problem/15863684>

[Timothy Hatcher]

Created attachment 221699 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 221699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221699&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:311
> +            // We have a current time alredy, so we likely need to jump into the future to a better current time.

Typo: alredy => already

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:378
>      _recordingReset: function(event)
>      {
> -        this._startTimeNeedsReset = true;
>          this._currentTime = NaN;
>  
> +        if (!this._updating) {
> +            // Force the time ruler and views to reset to 0.
> +            this._startTimeNeedsReset = true;
> +            this._updateTimes(0, 0, 0);
> +        }
> +
> +        this._lastUpdateTimestamp = NaN;
> +        this._startTimeNeedsReset = true;

Should this also delete this._waitingToResetCurrentTime if it was waiting? Seeing as we just deleted currentTime.

[Joseph Pecoraro]

Does the main navigator forward/back buttons update as expected? This could ravage the back/forward list of views, just double check that still works as expected.

[Timothy Hatcher]

https://trac.webkit.org/changeset/162422