Bug 127301 - CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
Summary: CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 12:44 PST by Mark Hahnenberg
Modified: 2014-01-20 14:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2014-01-20 13:14 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-01-20 12:44:06 PST 
We used to just call CodeBlock::visitAggregate, but now we call visitChildren on the ownerExecutable, which is unnecessary. We should go back to the old way of doing things.
Comment 1 Mark Hahnenberg 2014-01-20 13:14:08 PST 
Created attachment 221684 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-20 14:13:02 PST 
Comment on attachment 221684 [details]
Patch

Clearing flags on attachment: 221684

Committed r162377: <http://trac.webkit.org/changeset/162377>
Comment 3 WebKit Commit Bot 2014-01-20 14:13:04 PST 
All reviewed patches have been landed.  Closing bug.