Bug 127293 - Bindings generation tests hit an error trying to include wtf/Platform.h after r161638
Summary: Bindings generation tests hit an error trying to include wtf/Platform.h after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 09:04 PST by Alexey Proskuryakov
Modified: 2014-01-24 09:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2014-01-23 12:34 PST, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-20 09:04:45 PST 
<http://trac.webkit.org/changeset/161638> added an include of wtf/Platform.h in Source/WebCore/bindings/objc/PublicDOMInterfaces.h, which makes bindings test hit an error:

WebCore/bindings/objc/PublicDOMInterfaces.h:29:10: fatal error: 'wtf/Platform.h' file not found
#include <wtf/Platform.h>
         ^
1 error generated.


See e.g. <https://webkit-queues.appspot.com/results/5638167180869632>.
Comment 1 Alexey Proskuryakov 2014-01-22 09:45:43 PST 
Daniel, you added this line recently, could you please look into why this broke bindings tests?
Comment 2 Daniel Bates 2014-01-23 12:34:52 PST 
Created attachment 222016 [details]
Patch
Comment 3 WebKit Commit Bot 2014-01-23 12:36:58 PST 
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Comment 4 Daniel Bates 2014-01-24 09:45:56 PST 
Committed r162704: <http://trac.webkit.org/changeset/162704>