Bug 127273 – [GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[GTK][WK2] Move the rest of GTK's WorkQueue implementation to std::function

[Zan Dobersek]

Created attachment 221634 [details]
Patch

[WebKit Commit Bot]

Attachment 221634 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/WorkQueue.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:73:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:162:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:170:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 221634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221634&action=review

> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:73
> +        : EventSource(std::forward<std::function<void ()>>(function), workQueue)

This should just use std::move.

> Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp:170
> -    SocketEventSource* eventSource = new SocketEventSource(function, this, cancellable.get(), closeFunction);
> +    SocketEventSource* eventSource = new SocketEventSource(std::forward<std::function<void ()>>(function), this,
> +        cancellable.get(), std::forward<std::function<void ()>>(closeFunction));

This should use std::move instead of std::forward.

[Zan Dobersek]

Committed r162370: <http://trac.webkit.org/changeset/162370>