Bug 127270 - Web Inspector: Make the TimelineRecordTreeElement location subtitle live
Summary: Web Inspector: Make the TimelineRecordTreeElement location subtitle live
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-20 00:40 PST by Timothy Hatcher
Modified: 2014-01-20 19:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.71 KB, patch)
2014-01-20 00:47 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-20 00:40:22 PST 
Fix the FIXME about this.
Comment 1 Timothy Hatcher 2014-01-20 00:47:44 PST 
Created attachment 221629 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-01-20 00:59:46 PST 
<rdar://problem/15857024>
Comment 3 Joseph Pecoraro 2014-01-20 11:00:27 PST 
Comment on attachment 221629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221629&action=review

r=me

> Source/WebInspectorUI/UserInterface/SourceCodeLocation.js:55
> +    None: "none", // File name not included.
> +    Short: "short", // Only the file name.
> +    Full: "full" // Full URL is used.

Nit: would be nice to line up the comments. Makes reading what each does much easier.

> Source/WebInspectorUI/UserInterface/SourceCodeLocation.js:300
> +        // Legacy support for when nameStyle was fullURL and a boolean.
> +        if (!nameStyle || typeof nameStyle === "boolean")
> +            nameStyle = nameStyle ? WebInspector.SourceCodeLocation.NameStyle.Full : WebInspector.SourceCodeLocation.NameStyle.Short;

I'd rather we update the call sites to use the new enum and nameStyle is never a boolean.

> Source/WebInspectorUI/UserInterface/TimelineRecordTreeElement.js:40
> +        if (showFullLocationSubtitle)
> +            this._sourceCodeLocation.populateLiveDisplayLocationString(subtitle, "textContent");

Though the boolean says "showFullLocationSubtitle" it looks like this would defaults to the Short location subtitle.
Comment 4 Timothy Hatcher 2014-01-20 19:05:46 PST 
https://trac.webkit.org/changeset/162421