Fix the FIXME about this.
Created attachment 221629 [details]
Comment on attachment 221629 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=221629&action=review
> + None: "none", // File name not included.
> + Short: "short", // Only the file name.
> + Full: "full" // Full URL is used.
Nit: would be nice to line up the comments. Makes reading what each does much easier.
> + // Legacy support for when nameStyle was fullURL and a boolean.
> + if (!nameStyle || typeof nameStyle === "boolean")
> + nameStyle = nameStyle ? WebInspector.SourceCodeLocation.NameStyle.Full : WebInspector.SourceCodeLocation.NameStyle.Short;
I'd rather we update the call sites to use the new enum and nameStyle is never a boolean.
> + if (showFullLocationSubtitle)
> + this._sourceCodeLocation.populateLiveDisplayLocationString(subtitle, "textContent");
Though the boolean says "showFullLocationSubtitle" it looks like this would defaults to the Short location subtitle.