Bug 127266 – Add a nicer way to iterate over all the attributes of an element

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Add a nicer way to iterate over all the attributes of an element

[Benjamin Poulain]

Created attachment 221620 [details]
Patch

[Anders Carlsson]

Comment on attachment 221620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221620&action=review

> Source/WebCore/dom/ElementData.h:73
> +class AttributeIteratorAccessor {
> +public:
> +    AttributeIteratorAccessor(const Attribute* array, unsigned size)
> +        : m_array(array)
> +        , m_size(size)
> +    {
> +    }
> +
> +    AttributeConstIterator begin() const { return AttributeConstIterator(m_array, 0); }
> +    AttributeConstIterator end() const { return AttributeConstIterator(m_array, m_size); }
> +private:
> +    const Attribute* m_array;
> +    unsigned m_size;
> +};

I think you can use WTF::IteratorRange here instead.

[Geoffrey Garen]

Comment on attachment 221620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221620&action=review

r=me

Please consider Anders's suggestion.

> Source/WebCore/dom/ElementData.cpp:182
> +    unsigned count = length();

In cases like this, I prefer "unsigned length = this->length()" or "unsigned length = ElementData::length()". It's bad when one thing becomes two. Taking "length" and renaming it to "count" makes it seem like you've changed it somehow, which can be confusing.

[Benjamin Poulain]

(In reply to comment #2)
> I think you can use WTF::IteratorRange here instead.

My first idea was to just use the Attribute* as the iterator. But for some reason clang really sucks iterating with pointers :(

[Benjamin Poulain]

Committed r162394: <http://trac.webkit.org/changeset/162394>