Bug 127259 – [EFL][WK2] build fix after r162276

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

[ 88%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Platform/efl/WorkQueueEfl.cpp.o
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55:6: error: prototype for 'void WorkQueue::dispatch(const WTF::Function<void()>&)' does not match any in class 'WorkQueue'
In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:21:0:
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Platform/WorkQueue.h:60:10: error: candidate is: void WorkQueue::dispatch(std::function<void()>)
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63:82: error: no 'void WorkQueue::dispatchAfterDelay(const WTF::Function<void()>&, double)' member function declared in class 'WorkQueue'
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Platform/efl/WorkQueueEfl.cpp.o] Error 1

[Jinwoo Song]

Created attachment 221598 [details]
Patch

[Jinwoo Song]

Created attachment 221602 [details]
Patch

[Anders Carlsson]

Comment on attachment 221602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221602&action=review

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:37
> +    static std::unique_ptr<WorkItem> create(PassRefPtr<WorkQueue> workQueue, std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:39
>          return std::unique_ptr<WorkItem>(new WorkItem(workQueue, function));

Can to std::move(function) here

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:44
> +    WorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:46
>          , m_function(function)

Can do std::move(function) here.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57
> +    static std::unique_ptr<TimerWorkItem> create(PassRefPtr<WorkQueue> workQueue, std::function<void()> function, double delaySeconds)

Space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:60
>          return std::unique_ptr<TimerWorkItem>(new TimerWorkItem(workQueue, function, currentTime() + delaySeconds));

std::move(function).

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66
> +    TimerWorkItem(PassRefPtr<WorkQueue> workQueue, std::function<void()> function, double expirationTimeSeconds)

space after void.

> Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:67
>          : WorkItem(workQueue, function)

std::move(function).

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55
> +void WorkQueue::dispatch(std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:60
>      m_dispatchQueue->dispatch(WorkItem::create(this, function));

std::move(function).

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63
> +void WorkQueue::dispatchAfter(std::chrono::nanoseconds duration, std::function<void()> function)

space after void.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:68
> +    m_dispatchQueue->dispatch(TimerWorkItem::create(this, function, duration.count() / 1000000000ULL));

std::move(function).

[Jinwoo Song]

Created attachment 221606 [details]
Patch

Applied Andersca's comments.

[WebKit Commit Bot]

Attachment 221606 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 7 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 221606 [details]
Patch

Clearing flags on attachment: 221606

Committed r162300: <http://trac.webkit.org/changeset/162300>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.