Bug 127258 – Web Inspector: Generate better display names for timer and event Timeline records

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

The event record should say what event it was. And the timer record should optionally say what the timer identifier was.

[Radar WebKit Bug Importer]

<rdar://problem/15855340>

[Timothy Hatcher]

Created attachment 221597 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 221597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221597&action=review

r=me

> Source/WebInspectorUI/UserInterface/ScriptTimelineRecord.js:61
> +    if (details && !WebInspector.ScriptTimelineRecord._eventDisplayNames) {
> +        // These display names are not localized because they closely represent
> +        // the real API name, just with word spaces and Title Case.
> +
> +        var nameMap = new Map;
> +        nameMap.set("DOMActivate", "DOM Activate");
> +        nameMap.set("DOMCharacterDataModified", "DOM Character Data Modified");
> +        nameMap.set("DOMContentLoaded", "DOM Content Loaded");
> +        nameMap.set("DOMFocusIn", "DOM Focus In");
> +        nameMap.set("DOMFocusOut", "DOM Focus Out");

I wonder if a static object literal would be faster, or if this is negligible.

I think I'm actually in favor of seeing the actual event name. For example if I want to filter for a "beforecopy" event, I'll type that; not "Before Copy". So I could end up errantly not finding a record?

> Source/WebInspectorUI/UserInterface/ScriptTimelineRecord.js:178
> +        nameMap.set("webkitcurrentplaybacktargetiswirelesschanged", "Current Playback Target Is Wireless Changed");

My claim to fame.

> Source/WebInspectorUI/UserInterface/ScriptTimelineView.js:-46
> -    columns.details.title = WebInspector.UIString("Details");
> -    columns.details.width = "15%";
> -

Should we prefer this 15% be spread out to the others in some way? Give more to location?

[Timothy Hatcher]

https://trac.webkit.org/changeset/162420