Bug 127254 - Stop using MutexTryLocker in WebCore
Summary: Stop using MutexTryLocker in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-19 11:21 PST by Anders Carlsson
Modified: 2014-01-19 12:33 PST (History)
0 users

See Also:


Attachments
Patch (29.90 KB, patch)
2014-01-19 11:28 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-19 11:21:55 PST
Stop using MutexTryLocker in WebCore
Comment 1 Anders Carlsson 2014-01-19 11:28:35 PST
Created attachment 221591 [details]
Patch
Comment 2 Andreas Kling 2014-01-19 11:42:09 PST
Comment on attachment 221591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221591&action=review

Nice. r=me

> Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:97
> +    for (unsigned i = 0; i < m_kernels.size(); ++i)
> +        m_kernels[i]->process(source->channel(i)->data(), destination->channel(i)->mutableData(), framesToProcess);

range for?
Comment 3 Anders Carlsson 2014-01-19 12:30:43 PST
(In reply to comment #2)
> (From update of attachment 221591 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221591&action=review
> 
> Nice. r=me
> 
> > Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:97
> > +    for (unsigned i = 0; i < m_kernels.size(); ++i)
> > +        m_kernels[i]->process(source->channel(i)->data(), destination->channel(i)->mutableData(), framesToProcess);
> 
> range for?

Still need i for source->channel(i) and destination->channel(i) :(
Comment 4 Anders Carlsson 2014-01-19 12:33:33 PST
Committed r162296: <http://trac.webkit.org/changeset/162296>