JSC Parser: Shrink BindingNode.
Created attachment 221590 [details]
Comment on attachment 221590 [details]
I'm surprised that this matters, since the parse tree is a temporary data structure.
(In reply to comment #3)
> I'm surprised that this matters, since the parse tree is a temporary data structure.
These hang off of the VM's CodeCache.
Are you sure? The code cache stores an UnlinkedCodeBlock, which contains bytecode, not AST.
Hurgh, right you are! Something is keeping these objects alive though. Maybe we have a bug. :O
Maybe a leak?
Looks like these hang off of UnlinkedCodeBlock. UnlinkedFunctionExecutable has a FunctionParameters which contains a bunch of DeconstructionPatternNodes originating in the parser.
I see. We should be able to refactor and remove those. Can you send a bug to Oliver?
(In reply to comment #9)
> I see. We should be able to refactor and remove those. Can you send a bug to Oliver?
Hurk - yeah that's not ideal currently, it's deliberately held but i think reparsing of the arg list is probably the best approach.
Committed r162393: <http://trac.webkit.org/changeset/162393>