WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
127243
Switch the TextCheckerClient over to using StringView everywhere
https://bugs.webkit.org/show_bug.cgi?id=127243
Summary
Switch the TextCheckerClient over to using StringView everywhere
Sam Weinig
Reported
2014-01-18 18:01:38 PST
Switch the TextCheckerClient over to using StringView everywhere
Attachments
Patch
(77.40 KB, patch)
2014-01-18 18:02 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(77.35 KB, patch)
2014-01-18 21:15 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-01-18 18:02:41 PST
Created
attachment 221577
[details]
Patch
WebKit Commit Bot
Comment 2
2014-01-18 18:04:51 PST
Attachment 221577
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebKit/win/WebCoreSupport/WebEditorClient.h:106: The parameter name "detail" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/page/EditorClient.h:176: The parameter name "detail" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2014-01-18 21:15:43 PST
Created
attachment 221580
[details]
Patch
Anders Carlsson
Comment 4
2014-01-18 21:42:54 PST
Comment on
attachment 221580
[details]
Patch Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere
Sam Weinig
Comment 5
2014-01-19 10:50:17 PST
(In reply to
comment #4
)
> (From update of
attachment 221580
[details]
) > Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere
Yeah. Side note: I am not sure how I feel about this patch yet. The places where I replace the UChar*/length pair with StringView seem right, but the ones where I replace a String with a StringView aren't sitting well. Anders, do you have any thoughts on this?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug