Bug 127243 - Switch the TextCheckerClient over to using StringView everywhere
Summary: Switch the TextCheckerClient over to using StringView everywhere
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-18 18:01 PST by Sam Weinig
Modified: 2016-05-29 15:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (77.40 KB, patch)
2014-01-18 18:02 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (77.35 KB, patch)
2014-01-18 21:15 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-01-18 18:01:38 PST 
Switch the TextCheckerClient over to using StringView everywhere
Comment 1 Sam Weinig 2014-01-18 18:02:41 PST 
Created attachment 221577 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-18 18:04:51 PST 
Attachment 221577 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebKit/win/WebCoreSupport/WebEditorClient.h:106:  The parameter name "detail" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/EditorClient.h:176:  The parameter name "detail" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-01-18 21:15:43 PST 
Created attachment 221580 [details]
Patch
Comment 4 Anders Carlsson 2014-01-18 21:42:54 PST 
Comment on attachment 221580 [details]
Patch

Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere
Comment 5 Sam Weinig 2014-01-19 10:50:17 PST 
(In reply to comment #4)
> (From update of attachment 221580 [details])
> Pretty sure the StringView(const String&) constructor is implicit, no need for all those StringView(...) everywhere

Yeah.

Side note: I am not sure how I feel about this patch yet.  The places where I replace the UChar*/length pair with StringView seem right, but the ones where I replace a String with a StringView aren't sitting well.  

Anders, do you have any thoughts on this?