Bug 127233 - Remove view source code
Summary: Remove view source code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 128945
  Show dependency tree / graph
 
Reported: 2014-01-18 13:27 PST by Anders Carlsson
Modified: 2014-02-17 17:48 PST (History)
15 users (show)

See Also:

Attachments
Patch (74.57 KB, patch)
2014-01-18 13:29 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (81.77 KB, patch)
2014-01-18 13:46 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (85.29 KB, patch)
2014-02-17 15:17 PST, Anders Carlsson 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-18 13:27:26 PST 
Remove view source code
Comment 1 Anders Carlsson 2014-01-18 13:29:06 PST 
Created attachment 221567 [details]
Patch
Comment 2 Anders Carlsson 2014-01-18 13:46:19 PST 
Created attachment 221568 [details]
Patch
Comment 3 Anders Carlsson 2014-01-18 13:55:50 PST 
I'm going to hold off doing this until we've found a solution for the GTK+ port which exposes this as API.
Comment 4 Anders Carlsson 2014-02-17 15:17:14 PST 
Created attachment 224431 [details]
Patch
Comment 5 Antti Koivisto 2014-02-17 15:44:33 PST 
Comment on attachment 224431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224431&action=review

> Source/WebCore/css/DocumentRuleSets.cpp:103
> -void DocumentRuleSets::collectFeatures(bool isViewSource)
> +void DocumentRuleSets::collectFeatures()

Nice!
Comment 6 Anders Carlsson 2014-02-17 15:48:27 PST 
Committed r164254: <http://trac.webkit.org/changeset/164254>
Comment 7 Gyuyoung Kim 2014-02-17 17:25:58 PST 
EFL port has been broken since r164254. Coordinated Graphics is still using setMainFrameInViewSourceMode() and mainFrameInViewSourceMode(). Any reason to remove it ?

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/12942
Comment 8 Anders Carlsson 2014-02-17 17:33:33 PST 
(In reply to comment #7)
> EFL port has been broken since r164254. Coordinated Graphics is still using setMainFrameInViewSourceMode() and mainFrameInViewSourceMode(). Any reason to remove it ?
> 
> http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/12942

I'm sorry, I was unaware that the EFL port also used this API!

We're removing it for the reasons described in a previous WebKitGTK+ ChangeLog:

        This is a first step towards getting rid of the view source mode from WebCore. 
        View source shouldn't be a mode on the web page and can be implemented in other ways by
        embedding apps. Furthermore, the inspector has an excellent view source mode.