[...] Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl ................................... ok Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl ............................ 'tempdir' can't be called as a method at Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl line 120. Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl ............................ Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Tools/Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl ..................................... ok [...] That's because we're calling File::Temp->tempdir() but that's not supporte by the API.
Created attachment 221544 [details] Patch
This used to work in earlier Perl versions (although it was undocumented) but not anymore: https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565
Comment on attachment 221544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221544&action=review Are there any other call sites that use the bad syntax? > Tools/ChangeLog:8 > + Call the tempdir() function using the proper syntax. Although you document the commit that made the old syntax invalid, you may want to consider adding a remark that explains that we were using an undocumented calling convention and that this convention has been explicitly made invalid following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>. It would be great if we also documented the version of Perl this change affected.
(In reply to comment #3) > Although you document the commit that made the old syntax invalid, > you may want to consider adding a remark that explains that we were > using an undocumented calling convention and that this convention > has been explicitly made invalid following > <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>. It > would be great if we also documented the version of Perl this change > affected. Sure, I'll do that. The Perl version is 5.18.0, which included File::Temp v0.23 http://perldoc.perl.org/perl5180delta.html
Committed r162283: <http://trac.webkit.org/changeset/162283>
(In reply to comment #3) > (From update of attachment 221544 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221544&action=review > > Are there any other call sites that use the bad syntax? No, that was the only one.