Bug 127211 - Use unsigned type for the size of CSSParserValueList
Summary: Use unsigned type for the size of CSSParserValueList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 20:42 PST by Jinwoo Song
Modified: 2014-01-19 23:21 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.24 KB, patch)
2014-01-17 21:05 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2014-01-19 22:39 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-17 20:42:48 PST
The type of CSSParserValueList's size is unsigned.
Comment 1 Jinwoo Song 2014-01-17 21:05:13 PST
Created attachment 221529 [details]
Patch
Comment 2 Andreas Kling 2014-01-18 15:38:13 PST
Comment on attachment 221529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221529&action=review

> Source/WebCore/css/CSSParser.cpp:1798
> -    int num = inShorthand() ? 1 : m_valueList->size();
> +    unsigned num = inShorthand() ? 1 : m_valueList->size();

There's identical code on line 3499. Please make the same change there.
Comment 3 Jinwoo Song 2014-01-19 22:39:44 PST
Created attachment 221615 [details]
Patch

Applied Kling's comment.
Comment 4 WebKit Commit Bot 2014-01-19 23:20:59 PST
Comment on attachment 221615 [details]
Patch

Clearing flags on attachment: 221615

Committed r162305: <http://trac.webkit.org/changeset/162305>
Comment 5 WebKit Commit Bot 2014-01-19 23:21:01 PST
All reviewed patches have been landed.  Closing bug.