Bug 127204 - Silence a warning emitted when preprocessing mediaControlsApple.js
Summary: Silence a warning emitted when preprocessing mediaControlsApple.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 16:25 PST by Andy Estes
Modified: 2014-01-17 17:13 PST (History)
4 users (show)

See Also:


Attachments
Silence a warning emitted when preprocessing mediaControlsApple.js (1.51 KB, patch)
2014-01-17 16:26 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Work around a preprocessor warning in mediaControlsApple.js (1.51 KB, patch)
2014-01-17 16:43 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-01-17 16:25:30 PST
Silence a warning emitted when preprocessing mediaControlsApple.js
Comment 1 Andy Estes 2014-01-17 16:26:42 PST
Created attachment 221509 [details]
Silence a warning emitted when preprocessing mediaControlsApple.js
Comment 2 Eric Carlson 2014-01-17 16:41:13 PST
Comment on attachment 221509 [details]
Silence a warning emitted when preprocessing mediaControlsApple.js

View in context: https://bugs.webkit.org/attachment.cgi?id=221509&action=review

r=me, although my suggestion would be slightly cleaner if it works because we can still use the JS file as-is during development.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:839
>          return (time < 0 ? '-' : '' ) + String('00' + intMinutes).slice(-2) + ":" + String('00' + intSeconds).slice(-2)

I think you can also silence this warning by replacing the empty single-quotes with double-quotes: '' -> ""
Comment 3 Andy Estes 2014-01-17 16:43:12 PST
Created attachment 221511 [details]
Work around a preprocessor warning in mediaControlsApple.js
Comment 4 WebKit Commit Bot 2014-01-17 17:13:49 PST
Comment on attachment 221511 [details]
Work around a preprocessor warning in mediaControlsApple.js

Clearing flags on attachment: 221511

Committed r162233: <http://trac.webkit.org/changeset/162233>
Comment 5 WebKit Commit Bot 2014-01-17 17:13:52 PST
All reviewed patches have been landed.  Closing bug.