Bug 127202 - Clean up PageCache classes
Summary: Clean up PageCache classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 16:00 PST by Anders Carlsson
Modified: 2014-01-17 17:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (15.53 KB, patch)
2014-01-17 16:01 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (17.16 KB, patch)
2014-01-17 16:06 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-17 16:00:45 PST 
Clean up PageCache classes
Comment 1 Anders Carlsson 2014-01-17 16:01:53 PST 
Created attachment 221503 [details]
Patch
Comment 2 Anders Carlsson 2014-01-17 16:06:09 PST 
Created attachment 221506 [details]
Patch
Comment 3 Andreas Kling 2014-01-17 16:16:46 PST 
Comment on attachment 221506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221506&action=review

k

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1414
> -    OwnPtr<WebCachedFramePlatformData> webPlatformData = adoptPtr(new WebCachedFramePlatformData([m_webFrame->_private->webFrameView documentView]));
> -    cachedFrame->setCachedFramePlatformData(webPlatformData.release());
> +    auto webPlatformData = std::make_unique<WebCachedFramePlatformData>(m_webFrame->_private->webFrameView.documentView);
> +    cachedFrame->setCachedFramePlatformData(std::move(webPlatformData));

I'd get rid of the temporary here, since using it after this point would be an error anyway.
Comment 4 Anders Carlsson 2014-01-17 17:43:02 PST 
Committed r162234: <http://trac.webkit.org/changeset/162234>