[CSS Shapes] Preserve box-shape order when serializing shape values

[Bear Travis]

The shape-outside value 'content-box circle()' should serialize as 'content-box circle()' rather than 'circle() content-box'.

This is only true for non-computed styles, as the computed style places the box after the shape.

[Bear Travis]

Created attachment 221505 [details]
Initial Patch

[Bear Travis]

Created attachment 221688 [details]
Factoring code common to shapes and clipping

[Dirk Schulze]

Comment on attachment 221688 [details]
Factoring code common to shapes and clipping

View in context: https://bugs.webkit.org/attachment.cgi?id=221688&action=review

Patch looks great! Just some smaller snippets.

> Source/WebCore/css/CSSParser.cpp:5862
> +PassRefPtr<CSSValue> CSSParser::parseBasicShapeAndOrBox(bool allowBoundingBox)

Could you make that a static function or inline function please? Could you replace the boolean with a CSSPropertyID and check the id instead? That makes understanding the code easier.

> Source/WebCore/css/CSSParser.h:182
> +    PassRefPtr<CSSValue> parseBasicShapeAndOrBox(bool allowBoundingBox);

See comment above

[Bear Travis]

Created attachment 221780 [details]
Swapping boolean for CSSPropertyID

[Dirk Schulze]

Comment on attachment 221780 [details]
Swapping boolean for CSSPropertyID

r=me

[WebKit Commit Bot]

Comment on attachment 221780 [details]
Swapping boolean for CSSPropertyID

Clearing flags on attachment: 221780

Committed r162475: <http://trac.webkit.org/changeset/162475>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.