Bug 127189 - Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
Summary: Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 14:12 PST by Anders Carlsson
Modified: 2014-01-17 14:34 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.43 KB, patch)
2014-01-17 14:16 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-17 14:12:13 PST
Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
Comment 1 Anders Carlsson 2014-01-17 14:16:38 PST
Created attachment 221492 [details]
Patch
Comment 2 mitz 2014-01-17 14:20:17 PST
Comment on attachment 221492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221492&action=review

> Source/WebKit/mac/WebView/WebView.mm:2891
> +
> +    if (_private->_didPerformFirstNavigation)
> +        return;

Please remove.
Comment 3 Anders Carlsson 2014-01-17 14:34:39 PST
Committed r162224: <http://trac.webkit.org/changeset/162224>