Bug 127140 - FrameView compile fix for non-accelerated-compositing
Summary: FrameView compile fix for non-accelerated-compositing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Trivial
Assignee: Nobody
Depends on:
Reported: 2014-01-16 13:43 PST by Alex Christensen
Modified: 2014-01-16 17:47 PST (History)
3 users (show)

See Also:

Patch (1.12 KB, patch)
2014-01-16 13:46 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-01-16 13:43:42 PST
http://trac.webkit.org/changeset/162138 doesn't compile because RenderView:: backgroundRect requires a parameter.  In RenderView::backgroundRect, unscaledDocumentRect() is used if hasColumns() and hasExtendedBackground() are both false.  I'm not completely sure which rectangle to use.  Is this correct?

When I use accelerated compositing on WinCairo, will all ports use accelerated compositing?  Then we could get rid of all the non-accelerated-compositing code, right?
Comment 1 Alex Christensen 2014-01-16 13:46:32 PST
Created attachment 221410 [details]
Comment 2 Beth Dakin 2014-01-16 15:50:58 PST
Comment on attachment 221410 [details]

Thanks Alex!
Comment 3 WebKit Commit Bot 2014-01-16 17:47:08 PST
Comment on attachment 221410 [details]

Clearing flags on attachment: 221410

Committed r162176: <http://trac.webkit.org/changeset/162176>
Comment 4 WebKit Commit Bot 2014-01-16 17:47:10 PST
All reviewed patches have been landed.  Closing bug.