Bug 127135 - GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily
Summary: GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 12:39 PST by Myles C. Maxfield
Modified: 2014-02-11 17:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2014-01-28 13:03 PST, Myles C. Maxfield 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-01-16 12:39:17 PST 
GraphicsContext::drawLineForText in PLATFORM(IOS) saves and restores graphics context state unnecessarily
Comment 1 Myles C. Maxfield 2014-01-28 13:03:47 PST 
Created attachment 222475 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-01-28 14:58:02 PST 
Comment on attachment 222475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222475&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1461
> +    if (m_state.shouldUseContextColors)
> +#endif

I hate #ifdeffed control flow.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1474
> +        if (fillColorIsNotEqualToStrokeColor)
> +            setCGFillColor(platformContext(), fillColor(), fillColorSpace());

This indentation looks wrong.
Comment 3 Myles C. Maxfield 2014-02-11 17:54:14 PST 
Fixed in http://trac.webkit.org/changeset/163921