Bug 127114 - check-webkit-style should catch unnecessary explicit constructors
Summary: check-webkit-style should catch unnecessary explicit constructors
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 09:23 PST by BJ Burg
Modified: 2014-01-16 09:23 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-01-16 09:23:22 PST 
If you add 'explicit' to a constructor with >1 non-defaulted parameters, the style checker should complain. There's no point having explicit in that case.


Good:

explicit Foo();
explicit Foo(const String&);
explicit Foo(const String&, bool something = false);

Bad:

explicit Foo(Bar, Baz)