Bug 127106 - [GStreamer] media/video-canvas-drawing-output.html fails after bumping to 1.2.1
Summary: [GStreamer] media/video-canvas-drawing-output.html fails after bumping to 1.2.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 06:35 PST by Michal Pakula vel Rutka
Modified: 2017-09-27 12:27 PDT (History)
12 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2017-08-24 07:51 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-01-16 06:35:09 PST
Layout test media/video-canvas-drawing-output.html started to fail after bumping GStreamer to 1.2.1 in r160151 <http://trac.webkit.org/changeset/160151>
diff: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r162122%20%2812447%29/media/video-canvas-drawing-output-diff.txt
Comment 1 Philippe Normand 2014-03-05 00:51:26 PST
Here's the diff, in case the buildbot link expires.

--- /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/media/video-canvas-drawing-output-expected.txt
+++ /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/media/video-canvas-drawing-output-actual.txt
@@ -1,20 +1,20 @@
 
 EVENT(canplaythrough)
 EVENT(seeked)
-Saw close enough to (194, 193, 14) at (40, 165) OK
-Saw close enough to (17, 197, 195) at (56, 165) OK
-Saw close enough to (20, 200, 18) at (73, 165) OK
+Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL
+Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL
+Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL
 EVENT(seeked)
-Saw close enough to (194, 193, 14) at (40, 165) OK
-Saw close enough to (17, 197, 195) at (56, 165) OK
-Saw close enough to (20, 200, 18) at (73, 165) OK
+Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL
+Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL
+Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL
 EVENT(seeked)
-Saw close enough to (194, 193, 14) at (40, 165) OK
-Saw close enough to (17, 197, 195) at (56, 165) OK
-Saw close enough to (20, 200, 18) at (73, 165) OK
+Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL
+Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL
+Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL
 EVENT(seeked)
-Saw close enough to (194, 193, 14) at (40, 165) OK
-Saw close enough to (17, 197, 195) at (56, 165) OK
-Saw close enough to (20, 200, 18) at (73, 165) OK
+Expected (194, 193, 14) at (40, 165) but saw (192, 192, 11) FAIL
+Expected (17, 197, 195) at (56, 165) but saw (14, 196, 192) FAIL
+Expected (20, 200, 18) at (73, 165) but saw (17, 197, 15) FAIL
 END OF TEST
Comment 2 Philippe Normand 2014-03-05 00:52:09 PST
Also skipped in GTK.
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-24 07:51:38 PDT
Created attachment 318984 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2017-08-24 08:04:51 PDT
Comment on attachment 318984 [details]
Patch

I'm ok, but let's wait for Dino's green light as he wrote the test.
Comment 5 WebKit Commit Bot 2017-09-04 12:34:27 PDT
Comment on attachment 318984 [details]
Patch

Clearing flags on attachment: 318984

Committed r221591: <http://trac.webkit.org/changeset/221591>
Comment 6 WebKit Commit Bot 2017-09-04 12:34:29 PDT
All reviewed patches have been landed.  Closing bug.