Bug 12710 - REGRESSION: Buttons on Yahoo! Mail search results page set line-height too large
Summary: REGRESSION: Buttons on Yahoo! Mail search results page set line-height too large
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://mail.yahoo.com/
Keywords: InRadar, Regression, YahooBug
Depends on:
Blocks:
 
Reported: 2007-02-09 07:51 PST by David Kilzer (:ddkilzer)
Modified: 2008-12-23 23:18 PST (History)
3 users (show)

See Also:


Attachments
Screenshot of ginormous buttons (16.16 KB, image/png)
2007-02-09 07:53 PST, David Kilzer (:ddkilzer)
no flags Details
Test case (212 bytes, text/html)
2007-02-11 15:42 PST, David Kilzer (:ddkilzer)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2007-02-09 07:51:39 PST
Summary:

Delete, Spam, Mark and Move buttons are ginormous (humorously large) on Yahoo! Mail search results page.

Steps to reproduce:

1. Open Safari/WebKit.
2. Log into URL:  http://mail.yahoo.com/
3. Search for mail.

Expected results:

Delete, Spam, Mark and Move buttons should be the same size they are when viewing the Inbox.

Actual results:

Delete, Spam, Mark and Move buttons are ginormous.

Regression:

This is a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127).  Tested with a local debug build of WebKit r19497 with the aforementioned software.

Note:

http://www.urbandictionary.com/define.php?term=ginormous
Comment 1 David Kilzer (:ddkilzer) 2007-02-09 07:53:15 PST
Created attachment 13084 [details]
Screenshot of ginormous buttons
Comment 2 Maciej Stachowiak 2007-02-10 19:14:37 PST
<rdar://problem/4990048>
Comment 3 David Kilzer (:ddkilzer) 2007-02-11 15:42:20 PST
Created attachment 13125 [details]
Test case
Comment 4 David Kilzer (:ddkilzer) 2007-02-11 16:47:09 PST
Opening the test case (Attachment 13125 [details]) in Firefox 2.0.0.1, the line-height on the button is ignored.

In ToT WebKit r19565, Opera 9.10 and MSIE 6.0, the line-height on the button is not ignored and the button renders larger than it needs to be.

Thus, this is an evangelism issue.  This style rule needs to be adjusted for ToT WebKit:

div.taskbar button.button {
    line-height:2.5em;
}

The rule may be found in this file:

http://us.js2.yimg.com/us.yimg.com/lib/pim/r/y5/3_0_78/mail_us_blue.css

Comment 5 David Kilzer (:ddkilzer) 2007-02-11 16:53:49 PST
In shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037), the test case (Attachment 13125 [details]) button renders with a line height, but the actual search results page on Yahoo! Mail doesn't have the larger buttons.

The only conclusion I can come to is that either shipping Safari gets different styles, or the styles don't apply the same way as ToT WebKit.
Comment 6 Robert Blaut 2008-12-23 23:18:32 PST
I've tested the reported issue in the latest WebKit and I can say that the bug is fixed in Yahoo! Mail Classic.