Bug 127084 - [EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
Summary: [EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eunmi Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 00:10 PST by Eunmi Lee
Modified: 2014-01-16 21:23 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2014-01-16 00:19 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2014-01-16 16:03 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2014-01-16 16:58 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2014-01-16 00:10:01 PST
EwkView can be shown only if it is re-sized, so we can not show EwkView without re-sizing once it is hidden.
Comment 1 Eunmi Lee 2014-01-16 00:19:21 PST
Created attachment 221340 [details]
Patch
Comment 2 Ryuan Choi 2014-01-16 02:24:51 PST
Comment on attachment 221340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review

Nice. it was one of known issues, long time.

Comment looks little bit confusing to me, but I am not good with english.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305
> +        setNeedsSurfaceResize();

How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.
Comment 3 Eunmi Lee 2014-01-16 15:55:10 PST
Comment on attachment 221340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305
>> +        setNeedsSurfaceResize();
> 
> How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.

Thanks, it's better. I will update patch.
Comment 4 Eunmi Lee 2014-01-16 16:03:25 PST
Created attachment 221423 [details]
Patch
Comment 5 Gyuyoung Kim 2014-01-16 16:46:17 PST
Comment on attachment 221423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221423&action=review

> Source/WebKit2/ChangeLog:10
> +        to true for accelerated mode to prevent to show black empty view for

It looks this description is a little ambiguous.
Comment 6 Eunmi Lee 2014-01-16 16:58:14 PST
Created attachment 221427 [details]
Patch

Update Changelog.
Comment 7 Eunmi Lee 2014-01-16 21:23:06 PST
Comment on attachment 221427 [details]
Patch

Clearing flags on attachment: 221427

Committed r162182: <http://trac.webkit.org/changeset/162182>
Comment 8 Eunmi Lee 2014-01-16 21:23:15 PST
All reviewed patches have been landed.  Closing bug.