WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127084
[EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
https://bugs.webkit.org/show_bug.cgi?id=127084
Summary
[EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
Eunmi Lee
Reported
2014-01-16 00:10:01 PST
EwkView can be shown only if it is re-sized, so we can not show EwkView without re-sizing once it is hidden.
Attachments
Patch
(1.92 KB, patch)
2014-01-16 00:19 PST
,
Eunmi Lee
no flags
Details
Formatted Diff
Diff
Patch
(2.44 KB, patch)
2014-01-16 16:03 PST
,
Eunmi Lee
no flags
Details
Formatted Diff
Diff
Patch
(2.61 KB, patch)
2014-01-16 16:58 PST
,
Eunmi Lee
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Eunmi Lee
Comment 1
2014-01-16 00:19:21 PST
Created
attachment 221340
[details]
Patch
Ryuan Choi
Comment 2
2014-01-16 02:24:51 PST
Comment on
attachment 221340
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=221340&action=review
Nice. it was one of known issues, long time. Comment looks little bit confusing to me, but I am not good with english.
> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305 > + setNeedsSurfaceResize();
How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.
Eunmi Lee
Comment 3
2014-01-16 15:55:10 PST
Comment on
attachment 221340
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=221340&action=review
>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305 >> + setNeedsSurfaceResize(); > > How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.
Thanks, it's better. I will update patch.
Eunmi Lee
Comment 4
2014-01-16 16:03:25 PST
Created
attachment 221423
[details]
Patch
Gyuyoung Kim
Comment 5
2014-01-16 16:46:17 PST
Comment on
attachment 221423
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=221423&action=review
> Source/WebKit2/ChangeLog:10 > + to true for accelerated mode to prevent to show black empty view for
It looks this description is a little ambiguous.
Eunmi Lee
Comment 6
2014-01-16 16:58:14 PST
Created
attachment 221427
[details]
Patch Update Changelog.
Eunmi Lee
Comment 7
2014-01-16 21:23:06 PST
Comment on
attachment 221427
[details]
Patch Clearing flags on attachment: 221427 Committed
r162182
: <
http://trac.webkit.org/changeset/162182
>
Eunmi Lee
Comment 8
2014-01-16 21:23:15 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug