Bug 127084 – [EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Eunmi Lee]

EwkView can be shown only if it is re-sized, so we can not show EwkView without re-sizing once it is hidden.

[Eunmi Lee]

Created attachment 221340 [details]
Patch

[Ryuan Choi]

Comment on attachment 221340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review

Nice. it was one of known issues, long time.

Comment looks little bit confusing to me, but I am not good with english.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305
> +        setNeedsSurfaceResize();

How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.

[Eunmi Lee]

Comment on attachment 221340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221340&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:305
>> +        setNeedsSurfaceResize();
> 
> How about m_pendingSurfaceResize = m_isAccelerated; with removing m_pendingSurfaceResize from the initializer.

Thanks, it's better. I will update patch.

[Eunmi Lee]

Created attachment 221423 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 221423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221423&action=review

> Source/WebKit2/ChangeLog:10
> +        to true for accelerated mode to prevent to show black empty view for

It looks this description is a little ambiguous.

[Eunmi Lee]

Created attachment 221427 [details]
Patch

Update Changelog.

[Eunmi Lee]

Comment on attachment 221427 [details]
Patch

Clearing flags on attachment: 221427

Committed r162182: <http://trac.webkit.org/changeset/162182>

[Eunmi Lee]

All reviewed patches have been landed.  Closing bug.