AX: WebKit is not firing AXMenuItemSelectedNotification AXMenuItemSelectedNotification https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA-UAIG/1.0/tests/test-files/test94.html <rdar://problem/15668929>
Created attachment 221328 [details] patch
Comment on attachment 221328 [details] patch Attachment 221328 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/5416725646409728
(In reply to comment #2) > (From update of attachment 221328 [details]) > Attachment 221328 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/5416725646409728 this does not seem to be related, at least looking at the output
Comment on attachment 221328 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=221328&action=review Lgtm > Source/WebCore/accessibility/AXObjectCache.cpp:742 > + if (nodeHasRole(node, "menuitem") || nodeHasRole(node, "menuitemradio") || nodeHasRole(node, "menuitemcheckbox")) { Nit. I think an early return for this condition would be cleaner. I would also add a null check for node to the OR.
http://trac.webkit.org/changeset/162130 Thanks Mario!