RESOLVED FIXED127080
Move user agent code to WebCore and unify some code between OS X and iOS 
https://bugs.webkit.org/show_bug.cgi?id=127080
Summary Move user agent code to WebCore and unify some code between OS X and iOS
Benjamin Poulain
Reported 2014-01-15 20:58:50 PST
Move user agent code to WebCore and unify some code between OS X and iOS
Attachments
Patch (35.35 KB, patch)
2014-01-15 21:06 PST, Benjamin Poulain 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (483.47 KB, application/zip)
2014-01-15 22:22 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-01-15 21:06:13 PST
Created attachment 221327 [details] Patch
Build Bot
Comment 2 2014-01-15 22:22:02 PST
Comment on attachment 221327 [details] Patch Attachment 221327 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4670254961655808 New failing tests: http/tests/navigation/useragent.php
Build Bot
Comment 3 2014-01-15 22:22:04 PST
Created attachment 221333 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Sam Weinig
Comment 4 2014-01-15 22:33:08 PST
Comment on attachment 221327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221327&action=review r=me! > Source/WebKit/mac/WebView/WebView.mm:678 > - NSString *fullVersion = [[NSBundle bundleForClass:[WebView class]] objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey]; > + NSString *fullVersion = [[NSBundle bundleForClass:NSClassFromString(@"WKView")] objectForInfoDictionaryKey:(NSString *)kCFBundleVersionKey]; You should keep this calling [WebView class].
Benjamin Poulain
Comment 5 2014-01-15 22:38:39 PST
Committed r162114: <http://trac.webkit.org/changeset/162114>
Benjamin Poulain
Comment 6 2014-01-15 23:17:14 PST
Little follow up for iOS: http://trac.webkit.org/changeset/162116
Note You need to log in before you can comment on or make changes to this bug.