WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
127070
Add MarkedBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=127070
Summary
Add MarkedBlockInlines.h
Mark Hahnenberg
Reported
2014-01-15 15:27:18 PST
MarkedBlock.h is getting pretty unwieldy in terms of how many inline functions it has. MarkedBlock.cpp also contains some functions that could benefit from inlining, but which can't reside in MarkedBlock.h. It seems the time has come for MarkedBlockInlines.h.
Attachments
Patch
(45.29 KB, patch)
2014-03-26 11:55 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(55.58 KB, patch)
2014-03-26 12:02 PDT
,
Mark Hahnenberg
ggaren
: review-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2014-03-26 11:55:53 PDT
Created
attachment 227868
[details]
Patch
WebKit Commit Bot
Comment 2
2014-03-26 11:56:47 PDT
Attachment 227868
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 3
2014-03-26 12:02:38 PDT
Created
attachment 227869
[details]
Patch
WebKit Commit Bot
Comment 4
2014-03-26 12:03:25 PDT
Attachment 227869
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5
2014-03-26 20:26:24 PDT
Comment on
attachment 227869
[details]
Patch rs=me if you fix the build
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug