Bug 127070 - Add MarkedBlockInlines.h
Summary: Add MarkedBlockInlines.h
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 15:27 PST by Mark Hahnenberg
Modified: 2014-03-26 20:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (45.29 KB, patch)
2014-03-26 11:55 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (55.58 KB, patch)
2014-03-26 12:02 PDT, Mark Hahnenberg 		ggaren: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-01-15 15:27:18 PST 
MarkedBlock.h is getting pretty unwieldy in terms of how many inline functions it has. MarkedBlock.cpp also contains some functions that could benefit from inlining, but which can't reside in MarkedBlock.h. It seems the time has come for MarkedBlockInlines.h.
Comment 1 Mark Hahnenberg 2014-03-26 11:55:53 PDT 
Created attachment 227868 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-26 11:56:47 PDT 
Attachment 227868 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2014-03-26 12:02:38 PDT 
Created attachment 227869 [details]
Patch
Comment 4 WebKit Commit Bot 2014-03-26 12:03:25 PDT 
Attachment 227869 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/PropertyTable.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2014-03-26 20:26:24 PDT 
Comment on attachment 227869 [details]
Patch

rs=me if you fix the build