Bug 127062 - DumpRenderTree doesn't disable web preferences autosave
Summary: DumpRenderTree doesn't disable web preferences autosave
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 12:56 PST by Alexey Proskuryakov
Modified: 2014-01-15 14:39 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (1.28 KB, patch)
2014-01-15 12:58 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-15 12:56:55 PST 
Didn't we all assume that it disabled autosave?

I observed that running http/tests/security tests changed the value of -[WebPreferences privateBrowsingEnabled] in parallel DRT processes, which is horrible, because it could then easily get picked up by -[WebView _preferencesChanged:] any time it's called for any reason.
Comment 1 Alexey Proskuryakov 2014-01-15 12:58:33 PST 
Created attachment 221298 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-01-15 14:39:16 PST 
Comment on attachment 221298 [details]
proposed fix

Clearing flags on attachment: 221298

Committed r162092: <http://trac.webkit.org/changeset/162092>
Comment 3 WebKit Commit Bot 2014-01-15 14:39:17 PST 
All reviewed patches have been landed.  Closing bug.