Bug 127048 - [GTK][WK1] Add ProgressTrackerClient implementation
Summary: [GTK][WK1] Add ProgressTrackerClient implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 06:47 PST by Zan Dobersek
Modified: 2014-01-15 08:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (11.38 KB, patch)
2014-01-15 06:51 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-01-15 06:47:15 PST
[GTK][WK1] Add ProgressTrackerClient implementation
Comment 1 Zan Dobersek 2014-01-15 06:51:29 PST
Created attachment 221265 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-15 06:53:56 PST
Attachment 221265 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/GNUmakefile.am', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h', u'Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/ProgressTrackerClientGtk.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-01-15 07:24:18 PST
Comment on attachment 221265 [details]
Patch

Looks great, thanks for doing this!
Comment 4 Zan Dobersek 2014-01-15 08:59:39 PST
Comment on attachment 221265 [details]
Patch

Clearing flags on attachment: 221265

Committed r162069: <http://trac.webkit.org/changeset/162069>
Comment 5 Zan Dobersek 2014-01-15 08:59:44 PST
All reviewed patches have been landed.  Closing bug.