Bug 127036 - [EFL][WK2] Implement TestController::setHidden
Summary: [EFL][WK2] Implement TestController::setHidden
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-15 02:05 PST by Michal Pakula vel Rutka
Modified: 2014-01-16 06:09 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (1.58 KB, patch)
2014-01-15 02:37 PST, Michal Pakula vel Rutka
gyuyoung.kim: review+
Details | Formatted Diff | Diff
added error log (1.71 KB, patch)
2014-01-16 05:34 PST, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-01-15 02:05:21 PST
After r161105 four fast/events/page-visibility* tests started to fail. To fix them we need to implement TestController::setHidden.
Comment 1 Michal Pakula vel Rutka 2014-01-15 02:37:07 PST
Created attachment 221251 [details]
proposed patch
Comment 2 Ryuan Choi 2014-01-15 17:05:11 PST
Looks good to me.
Comment 3 Gyuyoung Kim 2014-01-15 20:05:50 PST
Comment on attachment 221251 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review

> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110
> +    if (!view)

Is there any possibility that platformView() is null ? Looks unneeded check.
Comment 4 Gyuyoung Kim 2014-01-15 20:18:57 PST
Comment on attachment 221251 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review

>> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110
>> +    if (!view)
> 
> Is there any possibility that platformView() is null ? Looks unneeded check.

I find a possibility platformView() can return null. It would be good if you print a log when view is null.
Comment 5 Michal Pakula vel Rutka 2014-01-16 05:34:32 PST
Created attachment 221369 [details]
added error log
Comment 6 WebKit Commit Bot 2014-01-16 06:09:52 PST
Comment on attachment 221369 [details]
added error log

Clearing flags on attachment: 221369

Committed r162123: <http://trac.webkit.org/changeset/162123>
Comment 7 WebKit Commit Bot 2014-01-16 06:09:56 PST
All reviewed patches have been landed.  Closing bug.