RESOLVED FIXED 127036
[EFL][WK2] Implement TestController::setHidden 
https://bugs.webkit.org/show_bug.cgi?id=127036
Summary [EFL][WK2] Implement TestController::setHidden
Michal Pakula vel Rutka
Reported 2014-01-15 02:05:21 PST
After r161105 four fast/events/page-visibility* tests started to fail. To fix them we need to implement TestController::setHidden.
Attachments
proposed patch (1.58 KB, patch)
2014-01-15 02:37 PST, Michal Pakula vel Rutka 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
added error log (1.71 KB, patch)
2014-01-16 05:34 PST, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2014-01-15 02:37:07 PST
Created attachment 221251 [details] proposed patch
Ryuan Choi
Comment 2 2014-01-15 17:05:11 PST
Looks good to me.
Gyuyoung Kim
Comment 3 2014-01-15 20:05:50 PST
Comment on attachment 221251 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review > Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 > + if (!view) Is there any possibility that platformView() is null ? Looks unneeded check.
Gyuyoung Kim
Comment 4 2014-01-15 20:18:57 PST
Comment on attachment 221251 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221251&action=review >> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:110 >> + if (!view) > > Is there any possibility that platformView() is null ? Looks unneeded check. I find a possibility platformView() can return null. It would be good if you print a log when view is null.
Michal Pakula vel Rutka
Comment 5 2014-01-16 05:34:32 PST
Created attachment 221369 [details] added error log
WebKit Commit Bot
Comment 6 2014-01-16 06:09:52 PST
Comment on attachment 221369 [details] added error log Clearing flags on attachment: 221369 Committed r162123: <http://trac.webkit.org/changeset/162123>
WebKit Commit Bot
Comment 7 2014-01-16 06:09:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.