Bug 127028 - [iOS] Crash in NavigatorBase::vendor loading apple.com
Summary: [iOS] Crash in NavigatorBase::vendor loading apple.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 18:38 PST by Joseph Pecoraro
Modified: 2014-01-14 20:22 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.39 KB, patch)
2014-01-14 18:41 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-14 18:38:13 PST 
iOS crash loading apple.com.

-- NavigatorBase.cpp

    String NavigatorBase::vendor() const
    {
        return WEBCORE_NAVIGATOR_VENDOR;
    }

-- config.h

    #if PLATFORM(IOS)
    #define WEBCORE_NAVIGATOR_PLATFORM wkGetPlatformNameForNavigator();
    #define WEBCORE_NAVIGATOR_VENDOR wkGetVendorNameForNavigator();
    #endif

--

Looks like we're missing calls to fill in these WKSI functions.
Comment 1 Joseph Pecoraro 2014-01-14 18:41:40 PST 
Created attachment 221224 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-01-14 20:22:08 PST 
Comment on attachment 221224 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 221224

Committed r162043: <http://trac.webkit.org/changeset/162043>
Comment 3 WebKit Commit Bot 2014-01-14 20:22:10 PST 
All reviewed patches have been landed.  Closing bug.