Bug 127011 - IDB: create object store support
Summary: IDB: create object store support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on: 127012
Blocks: 124521
  Show dependency treegraph
 
Reported: 2014-01-14 14:31 PST by Brady Eidson
Modified: 2014-01-16 14:02 PST (History)
3 users (show)

See Also:


Attachments
Patch v1 (48.22 KB, patch)
2014-01-14 14:39 PST, Brady Eidson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-14 14:31:18 PST
IDB: create object store support
Comment 1 Brady Eidson 2014-01-14 14:33:07 PST
In radar as <rdar://problem/15779639>
Comment 2 Brady Eidson 2014-01-14 14:39:13 PST
Created attachment 221204 [details]
Patch v1

This patch does most of the work.

It leaves out the (currently) nasty bit of (de)serializing the IDBKeyPath to and from disk, as we don't yet have a good solution to that.  Bug 127012 tracks that as a separate task.
Comment 3 WebKit Commit Bot 2014-01-14 14:40:36 PST
Attachment 221204 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBDatabaseMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBIndexMetadata.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStoreMetadata.h', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/CrossThreadCopier.cpp', u'Source/WebCore/platform/CrossThreadCopier.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h', u'Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in', u'Source/WebKit2/DatabaseProcess/IndexedDB/IDBSerialization.cpp', u'Source/WebKit2/DatabaseProcess/IndexedDB/IDBSerialization.h', u'Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp', u'Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h', u'Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h', u'Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp', u'Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h', u'Source/WebKit2/Scripts/webkit2/messages.py', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:349:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-01-14 18:52:46 PST
Comment on attachment 221204 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=221204&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:185
> +

No need for this newline.
Comment 5 Brady Eidson 2014-01-14 22:28:14 PST
http://trac.webkit.org/changeset/162047

But that does not close out this bug yet.  A small followup will be required either along with https://bugs.webkit.org/show_bug.cgi?id=127012 (blocking relationship already set) or as a separate patch here.
Comment 6 Brady Eidson 2014-01-16 13:41:45 PST
http://trac.webkit.org/changeset/162148 makes this work for reals.
Comment 7 Brady Eidson 2014-01-16 14:02:03 PST
http://trac.webkit.org/changeset/162151 as a build fix.